pedrovgs/Shot

Make focus consistent when taking screenshots

Open

#109 opened on May 11, 2020

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)Kotlin (111 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (1,208 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

We've been experimenting some flakiness because of the focus at the moment of taking the screenshot. It would be nice to have some consistency out of the box.

In some project we "clear" the focus we iterate over all the views, starting from the root view, and then requestFocusFromTouch() to make it consistent. In some other projects we take a view id that will be the one that will request the focus.

Contributor guide

Research direction
Examine the screenshot capture logic in Shot, then implement focus clearing by iterating over all views from the root and calling requestFocusFromTouch(). Verify on multiple API levels.
Tech stack
kotlin
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Android developmentKotlintesting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70