pedrovgs/KotlinSnapshot

When add snapshot name manually, it isn't extracting the class name

Open

#45 opened on Oct 3, 2018

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Kotlin (13 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (167 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behaviour

When enabling testClassAsDirectory = true and you add a snapshot name manually like snap.matchWithSnapshot(anyObject, "snapshot name"), It should add a folder with the class name and add a file with the name snapshot name.snap

Actual behaviour

testClassAsDirectory = true but when you add a custom snapshot name, it isn't creating any folder with the test class name.

Steps to reproduce

val snap = KotlinSnapshot(testClassAsDirectory = true)
snap.matchWithSnapshot(anyObject, "snapshot name")

Version of the library

1.0.0

Contributor guide

Research direction
Investigate the code path in KotlinSnapshot when a custom snapshot name is provided with testClassAsDirectory enabled. Look for where the class name folder is supposed to be created and see why it is not being added when a name is given.
Tech stack
kotlin
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
KotlinGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75