palantir/blueprint

ESLint deprecated component usage detector does not handle aliased imports

Closed

#6,408 opened on Sep 26, 2023

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
Domain: toolingP2Type: bughelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Environment

  • Package version(s): @blueprintjs/eslint-plugin: 5.0.0
  • Operating System: Windows 10/11

Steps to reproduce

  1. Use an aliased import of a deprecated BlueprintJS component somewhere:

import { DateInput as BlueprintDateInput } from "@blueprintjs/datetime";

  1. Use "plugin:@blueprintjs/recommended" in your eslintrc file.

Actual behavior

No errors detected.

Expected behavior

A message which tells that the usage of DateInput is deprecated.

  71:6  error  Usage of DateInput is deprecated, migrate to DateInput3 instead  @blueprintjs/no-deprecated-components

The error is properly displayed if we change the aliased import to a non-aliased import.

Contributor guide

Research direction
Examine the no deprecated components ESLint rule implementation to understand how it resolves imported component names. The rule likely uses the import's local name to detect deprecation, but aliased imports change the local name. You need to trace how the rule maps imports to deprecated components and find where the alias prevents detection. Consider fixing it by tracking the original imported name before aliasing.
Tech stack
typescriptreactjavascript
Domain
frontendtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsESLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60