palantir/blueprint

Enable strictNullChecks compiler option for all packages

Closed

#325 opened on Dec 6, 2016

View on GitHubContributor guide
 (9 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
Domain: toolinghelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

I think enabling strictNullChecks compiler option for datetime package will help us detect and prevent a whole host of potential errors, such as #322. it'll also address #274 by making the typings more accurate (as explicit null Dates actually means something in the component).

Contributor guide

Research direction
Add `strictNullChecks: true` to the TypeScript configuration for the `datetime` package (and then all other packages), and resolve any new type errors that arise.
Tech stack
typescriptreact
Domain
frontend
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55