osm-americana/openstreetmap-americana

Bannered shields cause neighboring shields to move too far down

Open

#340 opened on May 21, 2022

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)JavaScript (78 forks)auto 404
buggood first issuemaplibreshields

Repository metrics

Stars
 (238 stars)
PR merge metrics
 (Avg merge 91d 3h) (16 merged PRs in 30d)

Description

With shields along concurrent routes where one shield has more banners than another, the shield with fewer banners displays farther down on the screen than expected:

Screenshot from 2022-05-21 12-03-13

@ZeLonewolf:

It would require a change to maplibre to adjust the baseline for shields, or some other pixel gymnastics that I haven't thought of yet.

Contributor guide

Research direction
Investigate the maplibre shield rendering code to understand how the baseline is determined for bannered shields. Look for ways to adjust the vertical position of shields to prevent overlapping when banners are present. Consider modifying the glyph positioning logic or applying pixel offsets.
Tech stack
javascriptcss
Domain
frontendweb dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65