openzipkin/zipkin-js

Allow request sampler for server

Open

#437 opened on Aug 9, 2019

View on GitHub
 (1 comment) (2 reactions) (0 assignees)JavaScript (167 forks)auto 404
help wanted

Repository metrics

Stars
 (569 stars)
PR merge metrics
 (PR metrics pending)

Description

I have been checking the possibility of having the zipkin middleware only for specific routes and found it VERY cumbersome. My use case is that I don't want to trace _health calls in a node server.

Hence I want to open a discussion about requestSampler as we do have in zipkin-go and brave. This might do the trick, see https://github.com/openzipkin/zipkin-go/blob/master/middleware/http/server.go#L69

Ping @ghermeto @shumsky @adriancole

Contributor guide

Research direction
Examine the request sampler implementation in zipkin go and brave, then adapt it to the zipkin js middleware.
Tech stack
javascriptnodejs
Domain
backendobservability
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsZipkin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50