Remove atoi/atol from codebase · openssl/openssl

(7 comments) (0 reactions) (1 assignee)C (11,262 forks)batch import

backlog fixhelp wantedtriaged: feature

Repository metrics

Stars: (30,157 stars)
PR merge metrics: (No merged PRs in 30d)

Description

See this code search 'atoi' for the inventory Currently 39 hits (on Feb./2019).

and https://github.com/openssl/openssl/search?q=strtol&unscoped_q=strtol https://github.com/openssl/openssl/search?q=strtoul&unscoped_q=strtoul for the various ways of fixing it

Background details ( for ex.): http://www.eternallyconfuzzled.com/arts/jsw_art_atoi.aspx https://stackoverflow.com/questions/8871711/atoi-how-to-identify-the-difference-between-zero-and-error https://blog.mozilla.org/nnethercote/2009/03/13/atol-considered-harmful/

Contributor guide

Research direction: Identify all occurrences of atoi/atol in the codebase via the provided search links. For each, determine the context (e.g., input validation) and replace with strtol/strtoul with proper error checking.
Tech stack: c
Domain: securitybackend
Issue type: Refactor
Difficulty: 3
Estimated time: 3-5 days
Activity status: Active
Clarity: Mostly clear
Prerequisites: CGit
Newbie friendliness: 50