open-mmlab/mmengine

[Feature] `Visualizer` do not need `master_only` when saving image

Open

#1,081 opened on Apr 17, 2023

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Python (458 forks)github user discovery
good first issue

Repository metrics

Stars
 (1,486 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

What is the feature?

In Visualizer, saving image will using master_only function, when unsing multi-gpus, it will only save the master gpu images.

In my opinion, we can delete this (have tried and it works)

Any other context?

No response

Contributor guide

Research direction
Find the line with `master only` in the Visualizer's save image function and remove it to allow saving on all GPUs.
Tech stack
pythonpytorch
Domain
machine learningai
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonPyTorchGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85