open-duelyst/duelyst

[P3] Replace node-redis with ioredis

Open

#80 opened on Oct 2, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (526 forks)batch import
backendenhancementhelp wanted

Repository metrics

Stars
 (3,443 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

We're currently using node-redis@2.8.0, which has poor support for connection timeouts.

Replacing this with ioredis@5.2.3 fixes the above, but requires some changes. For example, the zrevrankAsync function does not exist, so we need to use zrevrank instead and remove the .then(result) chain.

Alternatively, upgrading node-redis may help with these issues.

See https://github.com/luin/ioredis/wiki/Migrating-from-node_redis

Contributor guide

Research direction
Follow the ioredis migration guide to replace node redis calls. Focus on converting `.zrevrankAsync` to `.zrevrank` and removing `.then()` chains.
Tech stack
javascriptnodejsredis
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.jsRedis
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60