open-duelyst/duelyst

[P0] Viewport / screen rotation should be disabled on Mobile

Open

#221 opened on Oct 29, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (526 forks)batch import
bugfrontendhelp wanted

Repository metrics

Stars
 (3,443 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Summary

The game should always operate in landscape mode. However, mobile browsers support screen rotation. Since this results in a viewport changed (and a forced app reload), let's disable screen rotation.

Impacted services

  • The frontend app
  • The game servers
  • Game builds or automation scripts
  • Tests or Github Actions
  • Infrastructure (Terraform)

Steps to reproduce

  1. Open https://staging.duelyst.org in a mobile browser
  2. Rotate the device

Environment information

  • Operating system: Android
  • Browser: Chrome
  • Browser version: Latest

Contributor guide

Research direction
Add a meta viewport tag with orientation=landscape or use CSS orientation lock to prevent screen rotation on mobile devices.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
HTMLCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85