onivim/oni

Language server over TCP

Open

#2,350 opened on Jun 24, 2018

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)TypeScript (297 forks)batch import
enhancementhelp wantedperformance

Repository metrics

Stars
 (11,250 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

As per https://langserver.org/ , language_server-ruby is very basic where as https://github.com/castwide/solargraph supports more capabilities.

Solargraph, however, only supports TCP; the author is suggesting he was getting more performant results over TCP vs stdio, this is why he kept TCP. ref: https://github.com/castwide/solargraph/issues/65

The author will take a look at stdio again but it would make sense for Oni to support TCP, especially it might be faster.

Contributor guide

Research direction
Examine the existing Language Server Protocol integration in Oni, focusing on how stdio transport is implemented (e.g., in `src/Editor/LanguageServer.ts` or similar). Create a new TCP transport class that follows the LSP JSON RPC over TCP specification. Ensure the new transport can be selected via configuration. Test with a language server like Solargraph that supports TCP.
Tech stack
typescriptnodejs
Domain
frontendtooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65