olistic/warriorjs

Check if unit is alive after effects

Open

#63 opened on May 8, 2018

View on GitHubContributor guide
 (8 comments) (0 reactions) (0 assignees)JavaScript (528 forks)batch import
good first issuepkg: corestatus: claimedtype: enhancement

Repository metrics

Stars
 (9,168 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

A negative effect could potentially kill a unit. We need to check if the unit is still alive after executing the effects and return early if the unit died. Example: a "poisoned" effect (it doesn't exist, at least yet) that damages the unit turn by turn.

Contributor guide

Research direction
Inspect the linked Unit.js file around line 98 to understand how effects are executed. Trace the async method and identify where to add a check for unit's health after effects. Consider returning early if health is zero or below.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75