oakmac/standard-clojure-style-js

Remove blank behaviour in different cases

Open

#156 opened on Nov 10, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (8 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (137 stars)
PR merge metrics
 (Avg merge 8h 9m) (8 merged PRs in 30d)

Description

Hi, just watched your conj talk, this is cool - your efforts are appreciated.

Came across two different cases in different editors Pic instead code block because it shows blankspaces.

In first case, which by default in my vscode setup will be formatted to

(cond
  :cond-1
  :do-1
  :cond-2
  :do-2
  :cond-3
  :do-)

but(which default in my cursive setup) will be formatted with respect to blank lines to

(cond
  :cond-1
  :do-1

  :cond-2
  :do-2

  :cond-3
  :do-)

I would personally prefer to respect empty lines, but I wonder which behavior is considered preferable and whether the formatter behaves correctly in both cases?

Contributor guide

Research direction
Investigate the formatter's handling of blank lines in different editor configurations. Trace the code path that processes whitespace and conditional groups. Determine whether the behavior should respect empty lines or ignore them consistently.
Tech stack
javascriptclojure
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80