nytimes/library

Add site access options for increased viewing permission granularity

Open

#7 opened on Mar 19, 2019

View on GitHubContributor guide
 (0 comments) (1 reaction) (0 assignees)JavaScript (148 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (1,180 stars)
PR merge metrics
 (PR metrics pending)

Description

Problem Description

Currently, Library utilizes domains to control who can access the site. However, this prohibits access on a person-by-person basis and increases the amount of maintenance needed when different aliases of the same domain are often used (ex: student@u.northwestern.edu versus student@northwestern.edu).

Feature

To address these issues, Library should support:

  • individual email address access via an environment variable and OAuth configuration
  • the use of regex for domain matching

Additional Information

Library accesses a user's email domain via the user's passport session and checks it against the APPROVED_DOMAINS config var.

Contributor guide

Research direction
Examine the current domain validation in server/userAuth.js and explore how to extend it to support individual email addresses and regex patterns.
Tech stack
javascriptnodejs
Domain
backendauthentication
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsOAuth
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60