nytimes/library

Make the Recently/Most Viewed Stories dropdown optional based on Datastore config

Open

#28 opened on May 28, 2019

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (148 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (1,180 stars)
PR merge metrics
 (PR metrics pending)

Description

Dropdown with Datastore Indexes set up:

Context (Environment)

A Library instance without Datastore Indexes set up.

Expected Behavior

Since setting up Datastore Indexes is optional, there should not be a dropdown if the indexes aren't set up.

Actual Behavior

Even without the indexes set up, an empty window still drops down. Screen Shot 2019-05-20 at 1 16 41 PM

Possible Solution

Enable/disable the dropdown depending whether the Datastore API/indexes are set up on the GCP project.

Contributor guide

Research direction
Investigate the condition that shows the dropdown and add a check for Datastore index configuration in the GCP project to conditionally hide or disable the dropdown.
Tech stack
javascript
Domain
full stack
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75