nytimes/library

Basic print style refinements

Open

#105 opened on Mar 27, 2020

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)JavaScript (148 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (1,180 stars)
PR merge metrics
 (PR metrics pending)

Description

It looks like hiding the fixed nav and the search bar would mostly solve this problem?

@afischer additions:_

Header

  • Logo, breadcrumbs should render at top. Long breadcrumbs should truncate with ellipses.
  • User initials/profile button should not render
  • Header should only be on first page, not repeating
  • Search bar, view all docs button should be hidden
  • Edit button should be hidden
  • side margins should be removed from title
  • HR should be removed? maybe? up to you.

Body

  • left and right margins should be removed, left text should be flush with logo at top of page
  • :before/:after elements on inline code should be removed
  • Images should not break between pages
  • Table rows should not break between pages
  • Tables of contents should not render

Footer:

  • "Pages in" block should be hidden
  • HR, buttons, footer text should all be hidden.

Contributor guide

Research direction
Investigate the existing print stylesheet in the repository (likely in CSS files) and add CSS rules to hide the specified elements (e.g., nav, search bar, edit button, footer elements) using media query @media print. Also ensure images and table rows do not break across pages using page break inside: avoid. Remove margins and adjust layout for print.
Tech stack
javascriptcss
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CSSHTML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75