nodejs/node

Run tests with OPENSSL_CONF set to embedded openssl.cnf

Open

#24,373 opened on Nov 15, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (35,535 forks)batch import
help wantedopensslstaletest

Repository metrics

Stars
 (117,218 stars)
PR merge metrics
 (Avg merge 13d 4h) (233 merged PRs in 30d)

Description

  • Version: <= 10.13.0
  • Platform: Linux

when building with the --shared-openssl flag, it is highly probable that the openssl.cnf used by the shared library will be different than the one present in Node.js source code, resulting in several test failures. Typically, on debian, openssl is configured with stricter options regarding key length and TLS versions. It is very easy to avoid any test failure, though, by setting this environment variable when running tests: OPENSSL_CONF=./deps/openssl/openssl/apps/openssl.cnf

Contributor guide

Research direction
Set OPENSSL CONF environment variable to the path of the bundled openssl.cnf before running tests. Look at the test suite to understand which tests fail and verify they pass with the configuration.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitBuild toolsOpenSSL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70