nodejs/llnode

Improved message for inspection of empty objects

Open

#253 opened on Dec 13, 2018

View on GitHubContributor guide
 (0 comments) (1 reaction) (0 assignees)C++ (101 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (1,167 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Right now, when you try to inspect an empty object, this is what you see:

(llnode) v8 i 0x000038e4d66492e1
0x000038e4d66492e1:<Object: Object >

This is a bit confusing, upon further inspection it looks like 0x000038e4d66492e1 is an empty object, {}. A more user friendly message could be very helpful.

PS. Big thanks to all the contributors on this project. Has been a lifesaver on multiple occasions.

Contributor guide

Research direction
Find the code that prints the object representation for V8 heap objects and add a check for empty objects to display a clearer message.
Tech stack
cpp
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70