nim-works/nimskull

Testament doesn't show a diff for nimout failures

Open

#257 opened on Mar 25, 2022

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Nim (39 forks)auto 404
buggood first issue

Repository metrics

Stars
 (346 stars)
PR merge metrics
 (PR metrics pending)

Description

Discovered by @zerbina attempting to run tests, they got an empty diff even though it was reported as a failure. This is for nimout related failures.

Example

Reproduction:

  • run koch.py test r tests/parser/tstatementoperators.nim
  • change the test such that it should fail
  • run the test again and get an empty diff
  • this was on windows

Actual Output

Shows the Expected and Gotten output but no diffs

Expected Output

A diff

Contributor guide

Research direction
Examine the testament source code in the Nim repository, specifically the part that generates diffs for nimout tests. Identify the code path that produces the diff and check for potential issues such as missing file handles or incorrect diff command execution. Pay special attention to Windows platform differences.
Tech stack
None
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
NimGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65