niieani/chunk-splitting-plugin

Compatibility with webpack 4

Open

#30 opened on Jun 20, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (4 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (15 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When trying to use this plugin with webpack v4, I'm getting the error:

const async = !chunk.isInitial()
                         ^

TypeError: chunk.isInitial is not a function
    at chunk (/Users/samypesse/Projects/GitBook/gitbook-new/node_modules/chunk-splitting-plugin/ChunkSplittingPlugin.js:156:26)
    at arrayMap (/Users/samypesse/Projects/GitBook/gitbook-new/node_modules/lodash/lodash.js:660:23)
    at map (/Users/samypesse/Projects/GitBook/gitbook-new/node_modules/lodash/lodash.js:9571:14)
    at flatMap (/Users/samypesse/Projects/GitBook/gitbook-new/node_modules/lodash/lodash.js:9274:26)
    at breakChunksIntoPieces (/Users/samypesse/Projects/GitBook/gitbook-new/node_modules/chunk-splitting-plugin/ChunkSplittingPlugin.js:155:10)

Contributor guide

Research direction
Investigate the usage of chunk.isInitial() which is not available in webpack 4; check the webpack 4 API for chunk relationship and replace with appropriate method.
Tech stack
javascriptnodejs
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptWebpack
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60