nightwatchjs/nightwatch

`frame()` command doesn't support page object element

Open

#3,655 opened on Mar 25, 2023

View on GitHub
 (7 comments) (0 reactions) (1 assignee)JavaScript (1,289 forks)batch import
buggood first issuehacktoberfest

Repository metrics

Stars
 (11,707 stars)
PR merge metrics
 (Avg merge 124d 5h) (1 merged PR in 30d)

Description

Description of the bug/issue

When I use frame() command, I expect the page object element can be used as a selector, but actually, it won't work.

Steps to reproduce

Try using frame() with a page object element.

Sample test

myPage.api.frame('@myIframe')

Nightwatch.js Version

2.6.14

Additional Information

See Discord discussion https://discord.com/channels/618399631038218240/1088668054650626058

David Burns - AutomatedTester — Yesterday at 21:33 I think this might need a bug raised. That doesn't seem right andrei — Today at 01:42 when using page objects, elements passed to commands on the .api namespace aren't resolved automatically. but we can easily add the frame() command on the main page object namespace Currently .frame() is implemented as a "protocol" command, so we will need to move it to the element-commands and update the implementation as needed. It's a relatively straightforward task.

Contributor guide

Research direction
Move the frame() command from protocol commands to element commands in the page object namespace. Modify the implementation to resolve page object elements before switching frames.
Tech stack
javascriptnodejs
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Nightwatch.jsPage Objects
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70