nextcloud/talk-android

No Notification because MagicFirebaseMessagingService.onDestroy is called

Open

#1,011 opened on Feb 15, 2021

View on GitHubContributor guide
 (7 comments) (0 reactions) (0 assignees)Kotlin (313 forks)auto 404
approvedbugfeature: notifications 🔔help wanted

Repository metrics

Stars
 (731 stars)
PR merge metrics
 (PR metrics pending)

Description

reproduce:

  1. Start new debug session (Build Variant: gPlayDebug )
  2. Make a call to the emulator

Issue: onDestroy is immediately called after receiving Push Notification. User won't recognize that someone tried to call. This happens (only?) on the first start of the debug session. So actually Push Notifications are delivered but somehow get discarded.

Temporarily made some log commands:

2021-02-15 16:28:52.229 31725-31958/com.nextcloud.talk2.debug D/MagicFirebaseMessagingService: start onMessageReceived
2021-02-15 16:28:52.231 31725-31958/com.nextcloud.talk2.debug D/MagicFirebaseMessagingService: start decryptMessage
2021-02-15 16:28:52.306 31725-31958/com.nextcloud.talk2.debug D/MagicFirebaseMessagingService: set MagicCallActivity as fullScreenIntent
2021-02-15 16:28:52.325 31725-31958/com.nextcloud.talk2.debug D/MagicFirebaseMessagingService: start checkIfCallIsActive
2021-02-15 16:28:52.343 31725-31958/com.nextcloud.talk2.debug D/MagicFirebaseMessagingService: startForeground for Notification
2021-02-15 16:28:52.370 31725-31725/com.nextcloud.talk2.debug D/MagicFirebaseMessagingService: start onDestroy
  • examine how often this happens. Is this really "only" for the first time after startup?

related: https://github.com/firebase/quickstart-android/issues/933

Contributor guide

Research direction
Investigate why MagicFirebaseMessagingService.onDestroy is called immediately after onMessageReceived. Check if the service is being killed by the system due to foreground service timeout or improper lifecycle handling. Reproduce with fresh debug session and examine service priority and startForeground usage.
Tech stack
kotlinandroidfirebase
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Android developmentFirebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40