nextcloud/passman

Postgres Sharing issue

Open

#581 opened on May 13, 2019

View on GitHubContributor guide
 (0 comments) (0 reactions) (1 assignee)JavaScript (115 forks)auto 404
Mediocre issuebuggood first issue

Repository metrics

Stars
 (821 stars)
PR merge metrics
 (PR metrics pending)

Description

There is an issue with sharing credentials while using a postgres database the query at https://github.com/nextcloud/passman/blob/master/lib/Db/ShareRequestMapper.php#L64

Postrgre does not support this kind of grouping so it should be achieved another way.

The error is: An exception occurred while executing 'SELECT *, target_user_id FROM oc_passman_share_request WHERE item_guid = ? GROUP BY target_user_id;' with params ["FFDAF598-D722-4095-9BEC-B18884DE66BF"]: SQLSTATE[42803]: Grouping error: 7 ERROR: column "oc_passman_share_request.id" must appear in the GROUP BY clause or be used in an aggregate function LINE 1: SELECT *, target_user_id FROM oc_passman_share_request WHERE...

This seems to be affecting new share requests, can't test it more deeply right now, i'm afraid.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Research direction
Rewrite the SQL query in ShareRequestMapper.php to be PostgreSQL compatible by replacing SELECT * with explicit columns and ensuring GROUP BY includes all non aggregated columns, or use a subquery.
Tech stack
phpjavascriptsqlpostgresql
Domain
backenddatabaseapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPSQLPostgreSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60