neo4j-contrib/neo4j-on-cloud-foundry

[Adapter] Introduce real Range type instead of "1000-30000" strings

Open

#8 opened on Oct 20, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Kotlin (1 fork)github user discovery
good first issuenice-to-have

Repository metrics

Stars
 (0 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

We should use a proper type instead of using String in the Update section of the Plan passed to produce the Manifest for the canary_watch_time and update_watch_time (see http://docs.pivotal.io/svc-sdk/odb/0-18/creating.html#plan-json-schema).

We'll need to create and register a custom Gson TypeAdapter for this Range type for Gson to be able to deserialize the Plan passed as parameter.

Contributor guide

Research direction
Research how to implement a custom Gson TypeAdapter for a new Range type. Study the existing Plan update section to understand the current string format and define a Range class. Then implement the adapter and register it in the Gson instance used for deserialization.
Tech stack
kotlin
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
KotlinGson
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75