mytakedotorg/mtdo

Replace UserNav Login link with a LoginModal

Open

#371 opened on Sep 4, 2020

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Java (3 forks)auto 404
frontendgood first issue

Repository metrics

Stars
 (16 stars)
PR merge metrics
 (PR metrics pending)

Description

When there is no user session present, the Login link at the top right of the header should launch a LoginModal component. Use VideoResultsList.tsx as an example.

Do not link to /login

https://github.com/mytakedotorg/mytakedotorg/blob/5f4bc71ccd44bb541522242f9936c77de381e724/client/src/main/scripts/components/search/VideoResultsList.tsx#L53-L55

Contributor guide

Research direction
Look at VideoResultsList.tsx around lines 53-55 to understand how LoginModal is used, then replicate that pattern in the header navigation component to replace the Login link.
Tech stack
reacttypescript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75