mozilla-mobile/firefox-ios

[Glean] Migrate TermsOfUseTelemetry to use the GleanWrapper instead

Closed

#29,805 opened on Oct 3, 2025

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)Swift (3,203 forks)batch import
Contributor OKGood first issue

Repository metrics

Stars
 (12,950 stars)
PR merge metrics
 (Avg merge 3d 2h) (221 merged PRs in 30d)

Description

:rocket: Context

TermsOfUseTelemetry is recording telemetry events with the concrete Glean implementation. We don't want this anymore. More on telemetry tests here.

:memo: Description

  • Use the GleanWrapper inside TermsOfUseTelemetry and replace calls to each GleanMetrics. with the corresponding API.
  • TermsOfUseTelemetryTests should be adjusted so we pass a MockGleanWrapper and assert accordingly.

:information_source: Reference Person

lmarceau

┆Issue is synchronized with this Jira Task

Contributor guide

Research direction
Examine existing files like `DefaultGleanWrapper` and `MockGleanWrapper` to understand the API. Replace direct `GleanMetrics.` calls in `TermsOfUseTelemetry` with `GleanWrapper.shared.*` equivalent methods. Update `TermsOfUseTelemetryTests` to inject `MockGleanWrapper` and verify calls.
Tech stack
swift
Domain
mobile
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftXCTest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65