moroshko/react-autosuggest

Warning about `componentWillReceiveProps` in React's Strict Mode

Open

#624 opened on Mar 16, 2019

View on GitHubContributor guide
 (9 comments) (54 reactions) (0 assignees)JavaScript (569 forks)batch import
help wanted

Repository metrics

Stars
 (5,940 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

React's Strict Mode warns about "Unsafe lifecycle methods were found within a strict-mode tree".

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead.

https://github.com/moroshko/react-autosuggest/blob/d626cef720df0ed5a4c7df4d539836b86bda6afa/src/Autosuggest.js#L124-L143

Contributor guide

Research direction
Replace componentWillReceiveProps with getDerivedStateFromProps as recommended by React Strict Mode warning.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75