mjackson/expect

Expected {} to equal {}

Open

#225 opened on Aug 21, 2017

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (115 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (2,270 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

> expect(Object.create(null)).toEqual({})
Error: Expected {} to equal {}

They are different, because of prototype, but the output is weird.

Contributor guide

Research direction
Examine the toEqual implementation to handle Object.create(null) and improve the error message to indicate prototype mismatch.
Tech stack
javascript
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75