mjackson/expect

whyNotEqual

Open

#153 opened on Aug 19, 2016

View on GitHub
 (1 comment) (2 reactions) (0 assignees)JavaScript (115 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (2,270 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I'm getting what appears to be a bogus error:

    Expected { app: { data: {}, ui: { fetchinUser: false, fetchingInstruments: false, fetchingLoans: false, modalOpen: false, modalView: null, selectedTab: 0, sidebarOpen: false, sidebarView: null, snackbarList: [], snackbarNextId: 0 } }, form: { search: { _active: 'query', _asyncValidating: false, _error: undefined, _initialized: false, _submitFailed: false, _submitting: false, query: { _isFieldValue: true, visited: true } } } } to equal { app: { data: {}, ui: { fetchinUser: false, fetchingInstruments: false, fetchingLoans: false, modalOpen: false, modalView: null, selectedTab: 0, sidebarOpen: false, sidebarView: null, snackbarList: [], snackbarNextId: 0 } }, form: { search: { _active: 'query', _asyncValidating: false, _initialized: false, _submitFailed: false, _submitting: false, query: { _isFieldValue: true, visited: true } } } }

It would be great is failed assertions would use whyNotEqual to report the issue:

https://www.npmjs.com/package/is-equal#want-to-know-why-two-values-are-not-equal

Contributor guide

Research direction
Inspect the existing deep equality implementation in the expect library and understand how to integrate the `is equal` package's `whyNotEqual` function to provide detailed failure messages.
Tech stack
javascript
Domain
testing qa
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70