mittwald/api-client-js

withAccessToken: allow dynamic tokens

Open

#46 opened on Mar 20, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)TypeScript (0 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (2 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/mittwald/api-client-js/pull/45 introduced the common interceptor withAccessToken.

If changing the access-token at runtime should be supported (what I suppose is a real-world-use-case), the withAccessToken interceptor is not the right solution, because it would require to create a new client and replace all usages.

Maybe the token parameter could be a function (executed in the interceptor) or a variable bag { token: string } what can be mutated during runtime – but this is a not so common and reasonable approach.

Contributor guide

Research direction
Explore implementing the `withAccessToken` interceptor to accept either a function returning a token or a mutable object containing the token, so that the token can be changed at runtime without creating a new client.
Tech stack
typescript
Domain
apiauthentication
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75