mitsuhiko/pipsi

Symlinked home directories prevents pipsi list from working

Open

#147 opened on May 24, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (135 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (1,994 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

On FreeBSD its common for /home/{name} to be symlinked to /usr/home/{name}. Without this adjustment, the paths never match the target path provided in args. The following code in list_everything, found in pipsi.py (python 2), fixes the issue.

def _find_venv(target): # Fix for base_prefix being a symlink to the real directory. # (eg: /home/<name>/ -> /usr/home/<name>/) for venv in venvs: base_prefix = join(self.home, venv, "") real_prefix = os.path.realpath(base_prefix) if target.startswith(real_prefix): return venv

Contributor guide

Research direction
Inspect the symlink issue in list everything and apply the provided fix, ensuring paths are resolved correctly using os.path.realpath.
Tech stack
python
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80