mitchelloharawild/vitae

Add tests for knit_print output

Closed

#110 opened on Apr 15, 2020

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)R (245 forks)batch import
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (1,273 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

#108 could have been prevented if knit_print tests captured this breaking change.

Adding test examples checking for knit_print output should provide reasonably detailed tests for brief_entries(), detailed_entries() and bibliography_entries() outputs.

Contributor guide

Research direction
Identify the functions brief entries(), detailed entries(), and bibliography entries() in the codebase and write testthat tests that verify the expected knit print output for each function.
Tech stack
r
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRtestthat
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65