mirumee/ariadne

Validate that root resolvers are set

Open

#187 opened on May 29, 2019

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Python (194 forks)batch import
enhancementhelp wantedto do

Repository metrics

Stars
 (2,342 stars)
PR merge metrics
 (Avg merge 12d) (3 merged PRs in 30d)

Description

Ariadne's make_executable_schema should by default check if fields on Query, Mutation and Subscription have set resolvers, and raise ValueError with appropriate type and field names to save dev from forgetting about those.

This option should be disableable in the case when API relies heavily on root_value or its only to keep schema browseable.

Contributor guide

Research direction
Implement validation of root resolvers in make executable schema function. Inspect existing resolver registration and raise ValueError if fields on Query, Mutation, Subscription lack resolvers. Include an option to disable this check.
Tech stack
python
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGraphQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70