milvus-io/milvus-operator

Add check to avoid `null` in config fields

Open

#227 opened on Feb 17, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (30 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (63 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

For manifest like this:

spec:
  config:
    common:
    #  security:
    #    authorizationEnabled: true
    etcd:
      rootPath: my-cluster

would assign null to spec.config.common.

Operator should be able to deny the call.

Contributor guide

Research direction
Look at how the config fields are unmarshalled from YAML and add a nil check in the validation code to reject null values.
Tech stack
go
Domain
infrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70