microsoft/windows-drivers-rs

blocklist certain warnings from bindgen

Open

#138 opened on Apr 9, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Rust (128 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (1,886 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/microsoft/windows-drivers-rs/blob/64108970944ae13f16ea109d03c841f804b82f21/crates/wdk-sys/build.rs#L73

Certain warnings from bindgen are not actionable by WDR due to upstream work required. These warnings should be individually silenced instead of turning off all warnings for the bindgen module. This is currently not possible because tracing's envfilter does not have functional field value matching for logs, only for spans. See https://github.com/tokio-rs/tracing/issues/2843. Since bindgen is using logs instead of traces, this probably involves fixing something in tracing-log

Contributor guide

Research direction
Investigate how to filter log messages from bindgen by message content. Explore options in tracing log or by using a custom log filter.
Tech stack
rust
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50