microsoft/cpprestsdk

reserved identifier violation

Open

#14 opened on Nov 10, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (1,670 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (7,596 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I would like to point out that identifiers like "_CASA_HTTP_CLIENT_H" and "_Value" do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

Contributor guide

Research direction
Inspect the referenced lines in http client.h and json.h, rename the identifiers to avoid reserved names (e.g., change ` CASA HTTP CLIENT H` to `CPPREST HTTP CLIENT H` and ` Value` to `Value `), and ensure the changes are consistent with the project's coding standards.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75