microsoft/Terminal

Some warnings aren't turned on

Open

#965 opened on May 23, 2019

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C++ (9,275 forks)batch import
Area-CodeHealthHelp WantedIssue-TaskProduct-Meta

Repository metrics

Stars
 (103,173 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

It looks like there's some warnings that are turned off by default. We should enable these and fix any instances of the warnings triggering as necessary.

Contributor guide

Research direction
Enable the specific compiler warnings listed in the Microsoft documentation for warnings that are off by default. Build the project and identify any instances where these warnings are triggered. Then fix each warning by modifying the code to comply with the warning rules.
Tech stack
cpp
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65