microsoft/Terminal

coding standards issue, _Upper should be banned

Open

#721 opened on May 12, 2019

View on GitHubContributor guide
 (2 comments) (10 reactions) (0 assignees)C++ (9,275 forks)batch import
Area-BuildHelp WantedIssue-BugProduct-ConhostProduct-Terminal

Repository metrics

Stars
 (103,173 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

the language standard reserves _Upper and __doubleUnderscore symbols for itself. windows coding standards recognize this as well, all _ prefixes on methods and other things with an upper case second letter should be renamed.

Contributor guide

Research direction
Find all identifiers matching the pattern ` [A Z]` in the codebase and rename them according to the project's naming conventions, ensuring no reserved identifiers remain.
Tech stack
ccpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60