microsoft/Terminal

Inconsistent gutters/margins on HiDPI displays with `snapToGridOnResize`

Open

#4,175 opened on Jan 10, 2020

View on GitHubContributor guide
 (15 comments) (12 reactions) (0 assignees)C++ (9,275 forks)batch import
Area-SettingsArea-TerminalControlHelp WantedIssue-BugPriority-3Product-Terminalgood first issue

Repository metrics

Stars
 (103,173 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

It looks like on my 200% scale device it's snapping at the half-grid.

A 50x15 window at 150% scale with Ctrl+Shift+A: image

After resizing the window to 51x15: image

Contributor guide

Research direction
Investigate the snap to grid functionality and trace how DPI scaling affects the computed gutter/margin sizes. Look for rounding errors in the coordinate calculations.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75