microsoft/Terminal

Add more `CommandlineTest` tests for `wt.exe` commandlines

Open

#4,168 opened on Jan 9, 2020

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C++ (9,275 forks)batch import
Area-CodeHealthHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (103,173 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Test excessively long text. Test empty text. Test text with ridiculous Unicode points in it like RTL/LTR/ZWJ/BOM. Test with invalid Unicode characters like the 0x80 0xc0 version of null.

Originally posted by @miniksa in https://github.com/microsoft/terminal/pull/4023

Contributor guide

Research direction
Examine existing CommandlineTest files to understand the test framework and patterns, then implement tests for long text, empty text, Unicode variations, and invalid Unicode sequences.
Tech stack
cpp
Domain
backendcli
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70