micrometer-metrics/micrometer

Apache HTTP Client connection metrics

Closed

#4,956 opened on Apr 9, 2024

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)Java (1,131 forks)batch import
enhancementhelp wantedinstrumentationmodule: micrometer-core

Repository metrics

Stars
 (4,882 stars)
PR merge metrics
 (Avg merge 1d 21h) (100 merged PRs in 30d)

Description

Please describe the feature request.

The Apache HTTP Client metrics do not include the timings and count for when new connections are created. Reactor Netty has this as reactor.netty.http.client.connect.time / reactor.netty.http.client.tls.handshake.time. It would be useful to create a Timer metric that calculated the time it took to form a new connection for Apache HttpClient

Rationale

These metrics are useful to see both how often new connections are created as well as how long those take. Using that information can provide better insight into configuring the connection pool.

Additional context

As an example, the Timer could be wrapped around the PoolingHttpClientConnectionManager.connect method to track this metric

Contributor guide

Research direction
Examine the existing Apache HTTP client metrics in Micrometer's codebase, likely in a dedicated module. The request is to add a Timer metric for connection creation time by wrapping `PoolingHttpClientConnectionManager.connect`. Follow patterns from Reactor Netty's `reactor.netty.http.client.connect.time` metric. Review the linked issue comments for any additional context or maintainer guidance.
Tech stack
java
Domain
observability
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaMicrometerApache HttpClient
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50