micrometer-metrics/micrometer

Add config option to compress Datadog payload

Closed

#2,297 opened on Oct 15, 2020

View on GitHubContributor guide
 (13 comments) (0 reactions) (0 assignees)Java (1,131 forks)batch import
enhancementhelp wantedregistry: datadogrelease notes

Repository metrics

Stars
 (4,882 stars)
PR merge metrics
 (Avg merge 1d 21h) (100 merged PRs in 30d)

Description

Compression cannot be enabled with DatadogConfig right now, but we do have the compress method on our abstract Request.Builder for HttpSender. Enabling compression by default seems reasonable and would help avoid the issue of going over the max payload size as mentioned in #1500.

Originally posted by @shakuzen in https://github.com/micrometer-metrics/micrometer/issue_comments/705314786

Contributor guide

Research direction
Locate the DatadogConfig interface and add a boolean compression option, then wire it into the HttpSender's request building logic to call compress() when enabled.
Tech stack
java
Domain
observability
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75