metosin/reitit

Bundled CORS-support

Open

#236 opened on Mar 11, 2019

View on GitHubContributor guide
 (9 comments) (22 reactions) (0 assignees)Clojure (261 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (1,569 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently, a third party mw/interceptor is needed for CORS. There should be a fast default mw & interceptor for this. Those could be configured either via route data or via mw/interceptor options. Example data format from https://github.com/metosin/reitit/issues/143#issuecomment-422079662:

{:access-control
 {:allow-origin "http://foo.example"
  :allow-methods #{:get :post :put}
  :allow-credentials true
  :allow-headers #{"X-PINGOTHER" "Content-Type"}
  :expose-headers #{"X-My-Custom-Header" "X-Another-Custom-Header"}
  :max-age 86400}}

Some prior work:

Related issues:

Contributor guide

Research direction
Study the existing ring cors library to understand CORS implementation, then design a middleware/interceptor for reitit that can be configured via route data or options.
Tech stack
None
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ClojureGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60