metosin/malli

Metadata-defined function schemas do not get reinstrumented by malli.dev

Open

#861 opened on Mar 5, 2023

View on GitHubContributor guide
 (2 comments) (1 reaction) (0 assignees)Clojure (237 forks)batch import
bughelp wanted

Repository metrics

Stars
 (1,724 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello :wave:

I have noticed that functions schemas defined with metadata do not get reinstrumented by malli.dev on namespace reload. Any change to the file and namespace reload causes instrumentation to stop working.

This issue does not happen when a function is instrumented with malli.core/=>.

See the video showing this happening on the newest [metosin/malli "0.10.2"]:

https://user-images.githubusercontent.com/4920654/222991613-2e22a9ef-faf9-4e94-91d6-0c7aed07a572.mov

I'm not sure if it's just a bug or a known limitation but it takes away the dev utility of metadata schemas.

Let me know if I could help you with fixing it and big thank you for the library and those dev instrumentation features!

Contributor guide

Research direction
Investigate the metadata handling in malli.dev's instrumentation lifecycle and how namespace reload affects it.
Tech stack
clojure
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Clojure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65