mesonbuild/meson

compiler.get_supported_arguments reports success for unsupported flags

Open

#5,355 opened on May 3, 2019

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)Python (1,465 forks)batch import
bugcompilersgood first issue

Repository metrics

Stars
 (4,978 stars)
PR merge metrics
 (Avg merge 139d 13h) (51 merged PRs in 30d)

Description

The has_argument and get_supported_argument methods are reporting success when the compiler returns an unsupported flag error to stderr.

I have attached a simple test case which demonstrates the error. The relevant meson.log entry is

Running compile:
Working directory:  /tmp/tmpygkykj04
Command line:  c++ /tmp/tmpygkykj04/testfile.cpp -pipe -D_FILE_OFFSET_BITS=64 -c -o /tmp/tmpygkykj04/output.obj -O0 -fpermissive -Wdeclaration-after-statement 

Code:
 int i;

Compiler stdout:
 
Compiler stderr:
 cc1plus: warning: command line option '-Wdeclaration-after-statement' is valid for C/ObjC but not for C++

Compiler for C++ supports arguments -Wdeclaration-after-statement: YES

meson.build.txt

Contributor guide

Research direction
Examine how `has argument` and `get supported argument` methods process compiler stderr output and ensure they check for error messages before reporting success.
Tech stack
python
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
MesonC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60