mesonbuild/meson

Add subdir argument to gnome.mkenums_simple() to match install_headers()

Open

#2,969 opened on Jan 24, 2018

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Python (1,465 forks)batch import
enhancementgnomegood first issuehelp wanted

Repository metrics

Stars
 (4,978 stars)
PR merge metrics
 (Avg merge 139d 13h) (51 merged PRs in 30d)

Description

Currently, to install my public headers and generated enums.h, I have to do something like:

includedir = join_paths(prefix, get_option('includedir'))
libblah_include_subdir = join_paths(libblah_api_name, 'libblah')
libblah_enums = gnome.mkenums_simple('enums',
  sources: libblah_headers,
  install_header: true,
  install_dir: join_paths(includedir, libblah_include_subdir),
)

# Public library bits.
install_headers(libblah_headers,
  subdir: libblah_include_subdir,
)

It would be good if gnome.mkenums_simple() took a subdir argument like install_headers, so that dealing with includedir directly was not necessary.

Contributor guide

Research direction
Find the implementation of `gnome.mkenums simple` in the Meson source code, likely in `mesonbuild/modules/gnome.py` or similar. Add a `subdir` keyword argument. When `install header` is true, compute the install directory by joining the value of `subdir` with the default install dir (or the provided `install dir` if any). Ensure the change is consistent with how `install headers` handles `subdir`. Update the documentation and add unit tests for the new feature.
Tech stack
python
Domain
build system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonMeson build system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75