mesonbuild/meson

coverage targets ?

Open

#2,953 opened on Jan 19, 2018

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Python (1,465 forks)batch import
buggood first issuehelp wanted

Repository metrics

Stars
 (4,978 stars)
PR merge metrics
 (Avg merge 139d 13h) (51 merged PRs in 30d)

Description

I'm trying to close the issue #2805, and i'm discovering something strange:

  • ninja coverage -> call meson --internal
  • ninja coverage-html -> call lcov
  • ninja meson-coverage -> call meson --internal (coverage alias)
  • ninja meson-coverage-html -> call lcov (coverage-html alias)

The calls to lcov are currently implemented twice, in scripts/coverage.py and backends/ninjabackend.py. And the implementations are not the same…

That should be cleaned. One solution is to write only ninja targets:

  • coverage-html : call lcov, genhtml (just like in scripts/coverage.py)
  • coverage-txt : call gcovr
  • coverage-xml : call gcovr
  • coverage : depends on the 3 other targets.

EDIT : I'm seeing that the move went from ninja targets to meson internal script. Is there a reason ? Anyway, one would suppose meson-* targets will call meson --internal, and that's not the case.

Contributor guide

Research direction
Compare the coverage implementations in scripts/coverage.py and backends/ninjabackend.py, then propose a unified set of ninja targets (coverage html, coverage txt, coverage xml, coverage) that call the appropriate tools (lcov, gcovr) consistently.
Tech stack
python
Domain
build system
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonNinja
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45