mesonbuild/meson

State corruption with multiple tasks running on same directory

Open

#2,922 opened on Jan 14, 2018

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Python (1,465 forks)batch import
buggood first issuehelp wanted

Repository metrics

Stars
 (4,978 stars)
PR merge metrics
 (Avg merge 139d 13h) (51 merged PRs in 30d)

Description

I ran ninja -C build after changing some options. At the middle, or towards the end, I hit ^Z to check on something. After checking, I totally forgot that the job was already running, and started it again. Realizing I had done that, I killed the new job, and resumed the old one. I got:

$ nice ninja -j4 -C armv7-build 
ninja: Entering directory `armv7-build'
[0/1] Regenerating build files.
Error during basic setup:

Something went terribly wrong. Please file a bug.
FAILED: build.ninja 
/usr/bin/python3.6 /home/ilia/src/meson/meson.py --internal regenerate /home/ilia/src/mesa-meson /home/ilia/src/mesa-meson/armv7-build --backend ninja
ninja: error: rebuilding 'build.ninja': subcommand failed

Do I now have to wipe the whole build directory and all the things that were already built in it?

Contributor guide

Research direction
Investigate how Meson handles multiple ninja instances and state files to prevent corruption. Look for possible race conditions in the build directory state management.
Tech stack
python
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonBuild Systems
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55