mesonbuild/meson

Add meson option to force color output when output is not tty

Open

#2,486 opened on Oct 12, 2017

View on GitHubContributor guide
 (2 comments) (8 reactions) (0 assignees)Python (1,465 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (4,978 stars)
PR merge metrics
 (Avg merge 139d 13h) (51 merged PRs in 30d)

Description

meson disables color output if stdout is not tty, as below:

mesonbuild/mlog.py:

colorize_console = platform.system().lower() != 'windows' and os.isatty(sys.stdout.fileno()) and \ os.environ.get('TERM') != 'dumb'

This works good normally. But colored log files are needed for sharing log across html email / link ( to pin point the exact areas of concern ( red / yellow warnings etc ). Colored output is much faster to debug than plain text. Screenshot is a very limiting option. An option to meson ( similar to ls --color=always ) should help here.

Example color log file:

root@vbox:~# apt-get install aha

set colorize_console = True in mesonbuild/mlog.py

user@vbox:/local/meson/source$ meson ../build | aha > ../build/log.html

meson-color-output

Contributor guide

Research direction
Add a new meson option (e.g., force color) that sets colorize console to True regardless of tty detection. Modify the logic in mlog.py to check this option before falling back to isatty detection.
Tech stack
python
Domain
build system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70