mesonbuild/meson

Substitute absolute path to files() when used in string formatting

Open

#1,592 opened on Apr 9, 2017

View on GitHubContributor guide
 (11 comments) (0 reactions) (0 assignees)Python (1,465 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (4,978 stars)
PR merge metrics
 (Avg merge 139d 13h) (51 merged PRs in 30d)

Description

From https://github.com/systemd/systemd/pull/5704#issuecomment-292796493:

But I have a trouble with makes files() work in more complicated cases: I need to a path to libudev.sym to specify it as a substring in -Wl,--version-script= option. I tried '-Wl,--version-script=' + libudev_sym '-Wl,--version-script=@0@'.format(libudev_sym)

In either of those two cases, we should substitute the absolute path to the files() object. I thought about relative paths, but there are too many corner-cases.

Contributor guide

Research direction
Investigate the current handling of files() objects in string formatting contexts within Meson's build file interpreter. Identify the code path where string interpolation occurs and where the absolute path of a files() object should be substituted. Implement the substitution logic and add tests.
Tech stack
python
Domain
build system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonMeson
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50